search

lucaargolo / kibe

A miscellaneous mod for Minecraft that adds a bunch of random, and mostly unoriginal things.
Mozilla Public License 2.0
46 stars 29 forks source link

Crash when a mob dies to spikes #133

Closed RSAmaro closed 2 years ago

RSAmaro commented 2 years ago

Just like the title says, I was building a mob farm, and for some reason, everytime a mob dies, it just crashes the server.

Modpack: Benchmark II 0.6.5

Crash Log crash.txt

lucaargolo commented 2 years ago

Please don't post crash reports directly in the issue message, it's horrible to read, just upload the file. Also this is being caused by PlayerEvents. They're casting all PlayerEntities to ServerPlayerEntities without actually checking if they're ServerPlayerEntities. https://github.com/ByMartrixx/player-events/blob/ed4108f2de03bb10d5481730b0094f0c6d4a8cdb/api/src/main/java/me/bymartrixx/playerevents/api/mixin/PlayerKillEntityMixin.java#L24 If they just change (entity instanceof PlayerEntity) to (entity instanceof ServerPlayerEntity) this would be fixed, and the code would be even cleaner cause those two casts could be avoided.

vaporvee commented 2 years ago

So this can be fixed in a future kibe update? or can only PlayerEvents fix this?

lucaargolo commented 2 years ago

PlayerEvents needs to fix it as changing my FakePlayer to a ServerPlayerEntity would break functionality with some features.

vaporvee commented 2 years ago

you can close this now it was fixed