lucaargolo / kibe

A miscellaneous mod for Minecraft that adds a bunch of random, and mostly unoriginal things.
Mozilla Public License 2.0
46 stars 29 forks source link

Items missing from EMI search #212

Open aagui5 opened 1 year ago

aagui5 commented 1 year ago

Many items are missing from EMI search, but still exist in the creative inventory and can still be crafted. Affects versions kibe-1.9.10+ for MC 1.19.2

The issue is not present in kibe-1.9.9-BETA+1.19

Steps to reproduce:

  1. Install kibe-1.9.10+ (any version above 1.9.9)
  2. Install latest version of EMI
  3. In-game, search keyword "@kibe", should see that many items are missing from search query, but still present in the creative inventory.
Bluetinity commented 1 year ago

The items are also missing in vanilla creative inventory search, and can only be found in the kibe creative inv tab.

Kisuny commented 1 year ago

same problem image

RemagOfficial commented 1 year ago

in most cases on REI is supported

Kisuny commented 1 year ago

in most cases on REI is supported

yes but https://github.com/emilyploszaj/emi/issues/227

RemagOfficial commented 1 year ago

in most cases on REI is supported

yes but https://github.com/emilyploszaj/emi/issues/227

but what, thats EMI not REI

Slayer5934 commented 1 year ago

https://github.com/lucaargolo/kibe/blob/1.19/src/main/kotlin/io/github/lucaargolo/kibe/blocks/BlockCompendium.kt

The blocks are not specifically registered here, that is likely why it is not showing for EMI or creative search..

Ristovski commented 1 year ago

@RemagOfficial

in most cases on REI is supported

yes but emilyploszaj/emi#227

but what, thats EMI not REI

If you were to read the comments in that issue, you would see that the real problem has nothing to do with EMI itself:

This is an issue because Kibe registers about half of its items in creative tabs but not the other half. EMI's metric for if a mod needs to have all of its items show up is if it only puts a small amount of them into creative tabs. I believe Kibe needs to resolve this by properly handling creative tabs.

This means that if Kibe was properly registering all items in creative tabs, they would not only show up on vanilla but EMI would be supported out of the box as well.

I assume REI simply shows all registered items instead, and currently Kibe seems to rely on this.

Kisuny commented 11 months ago

EMI author fix problem

image