search

lucab / libsystemd-rs

A pure-Rust client library to work with systemd
https://crates.io/crates/libsystemd
Other
105 stars 19 forks source link

check for mips targets for stat.st_dev definitions #103

Closed kraj closed 2 years ago

kraj commented 2 years ago

See https://sourceware.org/bugzilla/show_bug.cgi?id=17786

Signed-off-by: Khem Raj raj.khem@gmail.com

lucab commented 2 years ago

Thanks for the PR. Can you maybe add some details about where this showed up?

swsnr commented 2 years ago

I'd also appreciate a summary of the linked bug report; it's rather long, and I'm not sure what information or fact I should read from it.

swsnr commented 2 years ago

What Rust tier does the corresponding target belong to?

I'm asking because I'm not keen on maintaining architecture specific code here. If it's anything but a tier 1 target my vote would be to account for this mismatch for elsewhere, e.g. upstream libc or nix😬

I'm fine with using a different API at this place, as long as we don't have do deal with cfg here. Perhaps we can use std::fs::Metadata here somehow.

swsnr commented 2 years ago

I've opened #104 to use std::fs in this place instead of libc.

@kraj Please do test #104.

swsnr commented 2 years ago

@kraj Did you have a chance to test #104?

kraj commented 2 years ago

@kraj Did you have a chance to test #104?

in limited build only test it seems to be ok.

lucab commented 2 years ago

@kraj thanks for the additional feedback. I'd also prefer taking the rework in #104 to address this.

swsnr commented 2 years ago

I'm closing this in favour of #104 which I just merged 🙂