search

lucab / libsystemd-rs

A pure-Rust client library to work with systemd
https://crates.io/crates/libsystemd
Other
106 stars 19 forks source link

Use std API to extract journal stream from fd #104

Closed swsnr closed 2 years ago

swsnr commented 2 years ago

Follow up from #103

swsnr commented 2 years ago

@kraj Would you please test whether this change fixes your build error from #103?

swsnr commented 2 years ago

@lucab Pipeline fails because AsRawFd for RawFd is Rust 1.48 but MSRV in pipeline is still 1.46. Can we consider bumping to 1.48? Working around this would be a bit ugly :innocent:

lucab commented 2 years ago

Code changes looks good to me. Let's bump the MSRV to 1.48 in here too, it shouldn't be a concern for anybody at this time.

swsnr commented 2 years ago

@lucab Rebased onto master and bumped MSRV.

swsnr commented 2 years ago

Thanks for the review. I took the liberty of merging, following your approval 🙏