search

lucab / libsystemd-rs

A pure-Rust client library to work with systemd
https://crates.io/crates/libsystemd
Other
105 stars 19 forks source link

Add support for reading from the system journal #40

Open jabedude opened 4 years ago

jabedude commented 4 years ago

Closes #39.

This is a draft PR for adding support for reading from systemd's journal in pure rust.

jabedude commented 4 years ago

@lucab could you let me know if this looks like it’s on the right track to you?

jabedude commented 4 years ago

@lucab just checking back in to see if you have a moment to give any feedback 😊

lucab commented 4 years ago

@jabedude I went through you repo, lots of good stuff! But also a lot of things to read on my side :)

How do you want to proceed on this? Can we slowly move code over here? I'm happy to review if it can be split in a few human-sized chunks.

jabedude commented 4 years ago

@lucab thanks for the feedback! As for how to proceed: I'm not sure to be honest. I went back and forth whether my repo should be merged into libsystemd-rs or if it should be standalone. I do think that it makes sense to move things over here.

One reason for keeping it standalone would be how to make the core code available if someone wanted to say, re-implement systemd-journald in pure rust if that makes sense. Thoughts?

ip1981 commented 4 years ago

Maybe guard with a "feature"? :)