Closed vilgotf closed 2 years ago
Thanks for the PR. I think it is generally nice, but at the same time I think it got a bit out of hand and dragged in a lot of misc stuff. I'd suggest to unpack this into multiple commits/PRs so we can separately cover what to land and what to rework.
derive
feature from serde & manually impl Error instead of with thiserrortry_from_slice
in favour ofTryFrom<[u8]>
parse_str
in favor ofFromStr
Id128::from_boot
methodget_machine
in favor ofId128::from_machine
get_machine_app_specific
since it goes against the rust API guidelines (users should callId128::from_machine()?.app_specific()
instead)as_bytes
methodAsRef<[u8]>
,,AsRef<OsStr>
From<[u8; 16]>
,Copy
,Default
&Hash
^x.y.z
tox.y.z
as cargo interprets them the sameThis PR is to the best of my knowledge backwards compatible
Closes #78