Closed swsnr closed 3 years ago
@lucab Not sure if I've done this right, I'd appreciate a careful review :slightly_smiling_face:
I've added a GPG key, but I should like to point out that I'm likely going to replace the key; I ordered a security token for other reasons, but it happens to support hardware GPG keys, and should hopefully ship over the next few weeks. I'd make myself a new more secure key then, but I didn't want to wait, as the vendor has repeatedly delayed shipping due to the current global shortage of electronic parts.
Looks good! And I just learned that cargo-release
recently changed its default behavior in https://github.com/crate-ci/cargo-release/commit/5a0aeaf923bd356cd2767636ddd2b08e7090d6ed.
Did you also get a signed tag locally pointing to 28c8852
?
I do, but I guess I also already pushed that tag; I forgot that I had --follow-tags
enabled for push. Should I delete it again on Github with git push --delete
?
For this time, I think that doesn't cause real troubles, thus no need to delete and then re-push.
What I usually do is:
git fetch origin master:master
git checkout v0.4.0
cargo publish
git push origin v0.4.0
git checkout master
@lunaryorn you should have an invite for this on crates.io. Once confirmed, you should be able to proceed and publish the new crate version.
@lucab Yeah :blush: https://crates.io/crates/libsystemd
Nice! Final step would be to create a GH release. Mostly for aesthetic purposes, several external systems know how to link back to that.
Changes: