lucab / zbus_systemd

A pure-Rust library to interact with systemd DBus services
https://docs.rs/zbus_systemd
27 stars 7 forks source link

codegen: rewrite ztypes parser in nom #15

Closed bouk closed 1 year ago

bouk commented 1 year ago

I wasn't able to run the codegen because my dev setup is on macOS...

Related to #13

bouk commented 1 year ago

Figured out how to run the codegen! And it seems to work

bouk commented 1 year ago

Added back the context

lucab commented 1 year ago

Thanks for the PR, it looks good to me and I manually verified that there are no codegen regressions.

Could you please rebase against current main and re-run the code generator? I did a systemd bump to v253 in the meanwhile, so it would be better to refresh the generated code here.

As a sidenote, if you have https://github.com/casey/just installed locally then the whole refresh can be performed through just bump-systemd && just default.

bouk commented 1 year ago

Oh cool I'll add a note about just!

bouk commented 1 year ago

@lucab I've implement parsing dictionary signatures as well, which makes the parser complete!