Clarify which AWS service is doing the text-to-speech conversion

lucab85 / avg

Source of Docker image lucab85/avg https://quay.io/lucab85/avg

https://hub.docker.com/r/lucab85/avg

MIT License

5 stars 6 forks source link

Clarify which AWS service is doing the text-to-speech conversion #9

Closed jmernin closed 2 years ago

jmernin commented 2 years ago

Provide some additional detailed in the README about how the text-to-speech conversion is being done, so people can better understand the other values they could provide in the default.env file, for example.

In fact, perhaps we could add comments into default.env, pointing people to the relevant AWS page to see the available values for each variable.

lucab85 commented 2 years ago

Amazon option uses the Amazon Polly
Google option uses Cloud Text-to-Speech

jmernin commented 2 years ago

Maybe we also add some notes that also describe how to listen to samples of the voices that each service offers.

jmernin commented 2 years ago

I've submitted a PR to address this issue (see https://github.com/lucab85/avg/pull/13) so will close this issue once that PR is merged.

jmernin commented 2 years ago

PR above approved so closing this issue now too.