search

lucabaldini / ixpeobssim

Simulation and analysis framework for the Imaging X-ray Polarimetry Explorer
GNU General Public License v3.0
9 stars 12 forks source link

Significance calculation in kislat2015 needs to be fixed #727

Closed steveehlert closed 3 weeks ago

steveehlert commented 1 month ago

This is related to a previous update about the equivalent significance of a detection.

On line 616 of evt/kislat2015.py the current code in the function calculate_stokes_errors

sig[mask] = scipy.stats.norm.ppf(conf[mask])

should change to

sig[mask] = scipy.stats.norm.ppf(0.5 * conf[mask] + 0.5)

such that it matches line 528 in the function significance

lucabaldini commented 3 weeks ago

Implementing the change...

lucabaldini commented 3 weeks ago

Pull request: https://github.com/lucabaldini/ixpeobssim/pull/731

lucabaldini commented 3 weeks ago

Fixed and shipped in 31.0.2