lucabaldini / xpedaq

Data acquisition software for the X-ray polarimetry explorers
GNU General Public License v2.0
0 stars 0 forks source link

Refactor how the DAQ handles readout modes internally #85

Open lucabaldini opened 8 years ago

lucabaldini commented 8 years ago

Right now we organize the DAQ code around the concepts of redout mode (full frame vs. windowed) and buffer size (small vs large), while I gather we should really have three readout modes

  1. Full frame
  2. Windowed, small buffer
  3. Windowed, large buffer and no concept of buffer size.

This a somewhat complex change as it involves:

  1. Changing daq/xpoldetector.h/cpp (possibly adding an enum).
  2. Propagating the changes to pDetectorConfiguration. (Note this would also change the format of the configuration file.)
  3. Propagating all the changes to pXpolFpga, where we actually write the configuration.
  4. Changing the way pDataCollector and pDataBlock interact, with a unique pDataBlock constructor that we pass the readout mode to.
  5. Possibly changing the GUI, offering the three options and enabling the charge injection only when either of the windowed readout modes is selected.

(We should discuss more with Massimo whether charge injection in full-frame mode makes sense.)