search

lucabello / noctua

Helper tool for Canonical's Observability CI.
Apache License 2.0
0 stars 0 forks source link

`charmcraft.upload()` will only work in charmcraft 2.x #2

Open ca-scribner opened 2 months ago

ca-scribner commented 2 months ago

using the docker://name:tag format for charmcraft upload-resource --image only works in charmcraft 2. Not sure if that is a bug or by design from charmcraft.

As is, using noctua in place of charming-actions/upload will introduce a regression compared to charming-actions/upload because the charming actions upload pulls the image locally first then uses syntax that works on charmcraft 2 and 3.

lucabello commented 1 month ago

This syntax is supposed to work with Charmcraft 3, and it does on 3.2.0.post19+g13a3e049 (currently latest/edge). The regression was actually in 3.1.2 (currently latest/stable), but this API has been tested with 3.2.0.post19+g13a3e049 and Alex confirmed it should work.

Leaving it open until you can confirm, but if it doesn't work for you, we need to raise the issue to Charmcraft :)