search

lucacasonato / acme2

A Tokio and OpenSSL based ACMEv2 client for Rust.
https://docs.rs/acme2
Other
22 stars 8 forks source link

Implement external account binding (WIP) #21

Open paulgb opened 2 years ago

paulgb commented 2 years ago

This PR implements external account binding as specified in RFC 8555 and adds a test for it.

The functionality is all there, but I'm marking this as WIP as there are a few things I'd like to clean up (tests and error handling). If the general approach is acceptable, I'm happy to complete those tasks before merging.

paulgb commented 2 years ago

In addition to Pebble, I have successfully used this code for EAB ACME requests with ZeroSSL and Google's public CA.

plaidfinch commented 2 years ago

I would love to use this in a project I'm working on, and it would be great not to have to depend on the forked crate if possible. Can you give more details about what's needed to push this over the finish line and get it merged? Happy to help out!

paulgb commented 2 years ago

@plaidfinch I know you don't want to rely on the forked crate, but FYI it is in cargo as acme2-eab and we use it in some things, so we intend to maintain it there until it is merged upstream (if it ever is).

plaidfinch commented 2 years ago

I'm happy to rely on the forked crate if it's maintained, I just don't want to end up depending on something that will drift out of sync with upstream. So if you're good with maintaining it, I'm happy to use that!

paulgb commented 2 years ago

Yes, we use it in plane so we're happy to maintain the fork. I can't promise that we'll implement other new features, but we'll merge down upstream changes if any happen.

plaidfinch commented 2 years ago

@paulgb Great to hear, thanks for your work on this!