Closed andrewbrey closed 1 year ago
This morning, I decided to look into this more and forked the repository so that I could run the actions once I poked around with some changes. To my surprise, when I ran the ci.yml
workflow, everything came out just fine:
notice in the screenshot that the action used
deno 1.30.0
this lead me to think that the issue was something stale in my local DENO_DIR
caches, so I nuked all of my deno caches and let everything re-download/re-cache, and now everything is working as expected!
So, the good news is that I can close this issue I believe because I don't think this is an issue with deno-puppeteer
. I do not know what things I could have done differently to clue me into the need to nuke my cache sooner, but going forward, I think it'll be a standard triage step for me with Deno.
Leaving all this information here for posterity, but I'll go ahead an close this issue - cheers!
Thanks! I ran into the same issue.
For anyone else: You can find the location of your deno caches folder by running deno info
.
echo $DENO_DIR
didn't work for me.
First of all, thank you very much for your work on Deno, its ecosystem, in the TC39 as a deligate (
Response.json
wooo!), with Fresh, and in general in open source. It's extremely appreciated and you're doing a great job!This evening, after upgrading from
deno v1.29.4
todeno v1.30.0
I began to see the following error when I ran code which imports this module:Here is all that is needed to reproduce this error:
For context, here is information about my environment:
Also, I looked into this error a little (at the referenced line at the top of the stack trace https://deno.land/std@0.170.0/node/_core.ts:22:13 as well as the analogous code in the latest version of stdlib https://deno.land/std@0.174.0/node/_core.ts?source#L26), which prompted me to go into the repl and just see what I get when I check the availability of that internal
Deno-core
set of APIs, and found the following:so, apparently between
deno v1.29.4
anddeno v1.30.0
, something was moved out ofDeno.core
and intoDeno[Deno.internal].core
(if I'm reading this right). I did not check if this was just the fruition of a deprecation, but I wouldn't be surprised to learn that it was given that we just crossed a new minor.It's possible that all that's needed to address this is to bump the versions of the
stdlib
being used bydeno-puppeteer
but I wanted to surface this error in case there's something deeper going on.I looked around for alternate
puppeteer
modules for Deno, and found that this one, https://deno.land/x/deno_puppeteer@0.13.0, is able to run a simple script just fine for me:e.g.
but there are no others which worked when I tried for various reasons (most seem to be due to things being out of date).
Also weird, is that the GitHub repo associated with https://deno.land/x/deno_puppeteer@0.13.0 is 404'ing , and in fact, so is that entire user account...weird :grimacing: