search

lucachr / pelican-mg

A responsive, minimal theme for Pelican that uses UIkit.
MIT License
59 stars 34 forks source link

Remove synchronous XMLHttpRequest flag #2

Closed jakimfett closed 8 years ago

jakimfett commented 8 years ago

When "async: false" is set, the following error shows in the browser console (Firefox): Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience.

As "async: true" is the default, I also removed instances where async was explicitly set to true.

lucachr commented 8 years ago

First of all, thank you for contributing to mg. I'm sorry, but the patch that you submitted is relative to code that is included by the theme, but that I don't maintain, so I can't accept it. The changes, indeed, are relative to code from Disqus, Piwik, and Tipue Search. If I merge your patch with the code of the theme, I'll find myself having to maintain my own version of that code, or having to manually check and apply updates to the patched code from the vendors of the original one. Moreover, I think that the redundancy of "async:true" is needed for some retro-compatibility issues (probably IE 9). What I can recommend to you is to submit your patches to the vendors of the code included in mg, so that with the next release I can include the patched code from the vendors, without the need to maintain my own version of it.

jakimfett commented 8 years ago

Thanks for letting me know!