search

lucachr / pelican-mg

A responsive, minimal theme for Pelican that uses UIkit.
MIT License
59 stars 34 forks source link

Updating to work with Pelican 3.6.3 and uikit 2.23.0 #3

Closed bcl closed 8 years ago

bcl commented 8 years ago

I fixed page generation, updated uikit to 2.23.0, turned off trying to load disqus when not using it and added a way to disable search (which I didn't want to use, and it wasn't working anyway).

My articles were also being listed with the summary twice, I'm not sure if this is an artifact of my setup or if I am using a newer pelican than you are. Fixed that as well.

lucachr commented 8 years ago

Thank you for your contributions! I've merged 35ec435d3d60914d63c7156ce050e507b49cf802, 251f3da5f451d410f90993415b78a316353cad55, and 8f762102c2f6627ea5e893d877a0caf904d06abf. While I agree with you on the usefulness of a way to make search optional, I've decided to add an option in the configuration to disable search, rather than enable it. I did this for two reasons. The first one is that the new option is backward compatible with the old settings, so that other users of the theme don't need to update their config file to use the new version. The second one is that it follows the principle of the least astonishment, indeed I'm pretty confident that the majority of users expect that the theme has search enabled out of the box. Talking about the other issues, you said that search doesn't work, but to me seems that everything is ok. Did you set your config file according to the readme? There are some parameters that are required for search to work as expected (e.g.: DIRECT_TEMPLATES must contain 'search' and 'tipue_search'). Regarding the summaries of the articles, I think that you haven't added a summary to your articles, so in this case I guess that Pelican takes the first paragraph of your article as the summary, but I wait for your answer to know if I'm right or not.

lucachr commented 8 years ago

For now, I consider the issue as closed.