search

lucacorti / jsonapi_plug

JSON:API library for Plug and Phoenix applications
https://hexdocs.pm/jsonapi_plug
MIT License
11 stars 3 forks source link

Optimize underscore casing #63

Closed treere closed 2 months ago

treere commented 6 months ago

This should optimize the undescore casing.

I made this faster because it is used during query parsing

treere commented 6 months ago

I do not see a case where this code is different from the previous regex.

Macro.underscore does not fit this case. It does stuff with . like foo.bar becomse foo/bar

lucacorti commented 6 months ago

We are applying this to safe input because it's coming from the atoms used to describe the resource.

Anyway I'm fine with this.

lucacorti commented 4 months ago

@treere Do you want to merge this?

treere commented 4 months ago

@treere Do you want to merge this?

I will fix merging problem soon

treere commented 3 months ago

There is a small bug. I'm fixing it

lucacorti commented 2 months ago

There is a small bug. I'm fixing it

Any progress?

treere commented 2 months ago

I close this PR waiting a way to fix the bug in a clean way