Updates `nLines` flag to handle large file sizes

lucagrulla / node-tail

The zero dependency Node.js module for tailing a file

https://www.lucagrulla.com/node-tail/

MIT License

467 stars 75 forks source link

Closed MrDiggles2 closed 1 year ago

MrDiggles2 commented 1 year ago

No change to interface, this is strictly an implementation change.

Adds function getPositionAtNthLine to stream the file backwards instead of reading the entire file to get the correct position
Updates test for nLines to test for both windows and linux line endings

MrDiggles2 commented 1 year ago

@lucagrulla - Please let me know if you have any questions/suggestions!

lucagrulla commented 1 year ago

Thanks for this. I am quite busy these weeks, and I'm not sure when I will be able to review/merge/release. Hopefully soon 🙏

MrDiggles2 commented 1 year ago

@lucagrulla - Have you had a chance to look through this yet? Do you have any questions or concerns?

lucagrulla commented 1 year ago

Hey @MrDiggles2,

The main commit (SHA 03a9d2295fed7cd26a4478676cb555897787e6b2) looks good to me. Thanks for it!

I am unclear about the goal of these other two commits: 8f416621e0a3da73b627d98ce3081f1ac19c1fc1 d33ac5f51894315dfe4a3431c7d517ab4535ce68

Are those fixing backwards compatibility issues? Like pre Node 16? Or are you fixing something else?

MrDiggles2 commented 1 year ago

@lucagrulla - Great!

Those commits are compatibility fixes. I was using interfaces and functions from 18.x - those were changed to be backwards compatible down to Node 6