lucagrulla / node-tail

The zero dependency Node.js module for tailing a file
https://www.lucagrulla.com/node-tail/
MIT License
467 stars 75 forks source link

Possible regression at 2.2.0? #172

Open jmealo opened 8 months ago

jmealo commented 8 months ago

Hello,

Thanks for the excellent library. I make use of it in background-action (a GitHub action designed to block a step until a condition is met, using the wait-on library). It buffers stdout and stderr to files so the output can be tailed in GitHub actions, and optionally, output during the post-run step.

To eliminate duplicate output, it supports outputting only lines that weren't tailed (the resume option).

The test for resuming output begins failing with tail@2.2.0: https://github.com/JarvusInnovations/background-action/blob/9b4ab5bdc483d7f21f3d1c7da10144d5b327b264/test/success.test.js#L74

I've compared the versions and only see the addition of the nLines option. I haven't been able to track down the issue and will be locking in at 2.1.1 for now.

I'm posting this here in case anyone else encounters issues upgrading (or if you might have any ideas regarding the change in behavior?).

Thanks, Jeff