search

lucalanca / grunt-angular-architecture-graph

Generate modules dependencies graph in .dot format
MIT License
190 stars 13 forks source link

Fixed 0.2.4 breakage. Added the ability to configure the colour scheme. #10

Closed g1ps closed 9 years ago

g1ps commented 9 years ago

Resolves #2. Fixes #9.

lucalanca commented 9 years ago

Oh man, you're doing great work :+1: Will review this later today.

lucalanca commented 9 years ago

Merged and released under 0.2.5.

Thank you again for your contributions and please report if something is not working. I would just ask you to run "grunt" before commiting as this task runs the code style violations (using eslint) and grunt tests (that definitely need to be improved).

g1ps commented 9 years ago

Thanks. No problem but where? My system is built on grunt. Running grunt in the repo itself fails.

Cheers.

lucalanca commented 9 years ago

On this repository. It shouldn't fail now. Can you try and if it fails can you post the errors please?

g1ps commented 9 years ago

You've also got my 0.2.5 release notes under 0.2.4 as well. :wink:

lucalanca commented 9 years ago

Nice catch, fixed that :+1:

g1ps commented 9 years ago

On this repository. It shouldn't fail now. Can you try and if it fails can you post the errors please?

OK, grunt isn't installed locally and that's why it fails. I wouldn't normally want to pollute my repo. with code like that and then have to deal with it when committing, etc.. How do you want me to proceed, then?

Thanks.

g1ps commented 9 years ago

After finding .gitignore, I assume that those exclusions cover the scenario for you so they should work for me. I'll look further into that. :smile:

lucalanca commented 9 years ago

I personally prefer keeping the codebase consistent and that's why I enforce code styling rules.

You're free to not use them on your forked version. If so, I'll fix the styling violations before merging your PR myself (but if you follow the same rules, merging would be faster).

g1ps commented 9 years ago

I personally prefer keeping the codebase consistent and that's why I enforce code styling rules.

You're free to not use them on your forked version. If so, I'll fix the styling violations before merging your PR myself (but if you follow the same rules, merging would be faster).

I don't want to do that to you. I do the same. I'm happy to follow you but I'm afraid there seems to be something seriously wrong with the tests, though. I'm getting 8 dot processes, each using over 600MB RAM and crippling my system. A single run took over 5 mins! My document suite builds more images than the test (about 50) and the main one is much, much bigger than anything in the tests and that runs in under 20 secs. So something seems terribly wrong there.

Cheers.

Note: by "tests" I mean the grunt run.

lucalanca commented 9 years ago

OH, there's definitely strange. On my machine they run under a few seconds. I'll check what's happening. Will close this issue and create a new one for that.

ideadapt commented 8 years ago

Hello!

New message, please read http://radek.pomorze.pl/noble.php?q0tei

kunz@ideadapt.net