search

lucalanca / grunt-angular-architecture-graph

Generate modules dependencies graph in .dot format
MIT License
190 stars 13 forks source link

Missing shape: cds #7

Closed g1ps closed 9 years ago

g1ps commented 9 years ago

Hi there,

This may be more related to grunt-graphviz but it would be nice to resolve it.

I get "Warning: using box for unknown shape cds" on every attempt to create a module graph. My graphs therefore have the box shape where the cds shape is expected.

I only see the warnings in verbose mode. To replicate, just add "--verbose" to your grunt task command. It seems that the cds shape is missing from my version of grunt-graphviz. It was installed automatically as a dependency of this package, so that's unexpected. The version I have is 0.1.0.

Cheers.

g1ps commented 9 years ago

As a way of mediating this issue, and just because I wanted it, I have added the ability to configure which shapes are used and updated the readme again. It could be interesting to extend the concept and allow each entity type (directive, etc) to be configurable in this way but I haven't looked at that, yet.

I'd be glad of your comments as I'm not familiar with graphviz's template format, etc. It is working well for me, though.

It seems that this commit has been bundled in with #6. I expected to be able to create a separate request. Ho hum.

Available shapes are (supposedly) shown here: http://www.graphviz.org/doc/info/shapes.html

Cheers.

lucalanca commented 9 years ago

The ability to configure shapes is a nice one. Thank you for your contribution, again (you're on fire). Will review it over the weekend :+1:

lucalanca commented 9 years ago

I don't have this issue. Do you see any difference between the graphs that you generate and the ones on README.md?

lucalanca commented 9 years ago

Anyway, the configurable shapes is now on 0.2.4 release ;)

g1ps commented 9 years ago

I don't have this issue. Do you see any difference between the graphs that you generate and the ones on README.md?

Yes, I don't get the cds shapes I get boxes, as per the error. That shape doesn't seem to be in my graphviz module and it's not the only one that's missing.

lucalanca commented 9 years ago

Can you tell me which version of graphviz you use? I have installed graphviz using homebrew for OSX (I think you use windows by the issue you reported in https://github.com/lucalanca/grunt-angular-architecture-graph/issues/8) and the version I use is 2.38.0 (which is the latest, as per http://www.graphviz.org/Download_macos.php) 

> brew info graphviz
graphviz: stable 2.38.0 (bottled)
g1ps commented 9 years ago

Can you tell me which version of graphviz you use? I have installed graphviz using homebrew for OSX (I think you use windows by the issue you reported in #8) and the version I use is 2.38.0 (which is the latest, as per http://www.graphviz.org/Download_macos.php)

brew info graphviz graphviz: stable 2.38.0 (bottled)

Well done, you've hit on it. I didn't realise that grunt-graphviz was using external graphviz. An update solved it.

Cheers.