search

lucamug / style-framework

An experimental Style Framework built on top of elm-ui
https://package.elm-lang.org/packages/lucamug/style-framework/latest/
BSD 3-Clause "New" or "Revised" License
42 stars 8 forks source link

Style-Framework examples don't work on 0.19.1 #8

Open nova-nowiz opened 3 years ago

nova-nowiz commented 3 years ago

I have modified the FrameworkCustomized example for it to work on 0.19.1 if you want me to make a pull request @lucamug.

lucamug commented 3 years ago

Yes, thanks.

I will refresh the readme of this library too

nova-nowiz commented 3 years ago

As I was reviewing my modifications today, I realized that my pull request isn't acceptable. Basically, I had to change the module used in the framework in Configuration.elm from MyStyle to FrameworkConfiguration as MyStyle (FrameworkConfiguration being the file that I use to override the config): image Basically, it is a requirement to make a copy of the framework to do modifications on the configuration. My example fix for 0.19.1 is not local to the example. I should have said so in my previous comment. Another fix is to remove the MyStyle.elm file in the framework.

However, this customization problem #9 is not the only one as Flags don't work too. I had to put the initModel and initCmd functions in FrameworkCustomized.elm, modify them, and also modify the init function to make the example work.

I think a rewrite as a whole for might be necessary to make it work with the latest version of elm. Modifying the readme to state that this library can only be used in 0.19.0 and not in 0.19.1 is a good idea. Do you want me to still make a pull request so that you can view my changed @lucamug?

On another note, I saw on your github that you were working at rakuten and making the r10 package. do you think this is a good replacement for style-framework? And in this case, it might be a good idea to redirect users using 0.19.1 to this new library.