lucaong / jQCloud

jQuery plugin for drawing neat word clouds that actually look like clouds
MIT License
646 stars 293 forks source link

Tag spacing messed up when used with Twitter Bootstrap #24

Closed rsimon closed 12 years ago

rsimon commented 12 years ago

Hi! Thanks for jQCloud - works like a charm!

However, I used it with Twitter Bootstrap (http://twitter.github.com/bootstrap/), which messed up the tag layout. Tags were placed very closely, so that they overlapped heavily. The cause seemed to be that the Bootstrap CSS sets a global line-height property in the body.

I added a "line-height:normal" to the div.jqcloud CSS class, and this fixed it.

In other words: my problem is solved, but I just wanted to let you know in case you want to add that as well!

Cheers, Rainer

lucaong commented 12 years ago

Hi Rainer, Very good to know, thanks for your feedback. I will definitely add this. Cheers, Luca

On 17/lug/2012, at 09:03, Rainer Simonreply@reply.github.com wrote:

Hi! Thanks for jQCloud - works like a charm!

However, I used it with Twitter Bootstrap (http://twitter.github.com/bootstrap/), which messed up the tag layout. Tags were placed very closely, so that they overlapped heavily. The cause seemed to be that the Bootstrap CSS sets a global line-height property in the body.

I added a "line-height:normal" to the div.jqcloud CSS class, and this fixed it.

In other words: my problem is solved, but I just wanted to let you know in case you want to add that as well!

Cheers, Rainer


Reply to this email directly or view it on GitHub: https://github.com/lucaong/jQCloud/issues/24

lucaong commented 12 years ago

done :)

rsimon commented 12 years ago

Hi,

cool - another question: is the tag cloud supposed to "auto-scale" as to not exceed the width/height of the DIV? In my case, this doesn't work. See e.g.

http://pelagios.dme.ait.ac.at/api/places/http%3A%2F%2Fpleiades.stoa.org%2Fplaces%2F579885

for example which is correct, and

http://pelagios.dme.ait.ac.at/api/places/http%3A%2F%2Fpleiades.stoa.org%2Fplaces%2F805630

for an example which (most of the time) doesn't work perfectly.

If the tag cloud is supposed to scale, then this is probably another Bootstrap-related issue?

Cheers, Rainer

-----Ursprüngliche Nachricht----- Von: Luca Ongaro [mailto:reply@reply.github.com] Gesendet: Dienstag, 17. Juli 2012 10:36 An: Simon Rainer Betreff: Re: [jQCloud] Tag spacing messed up when used with Twitter Bootstrap (#24)

done :)


Reply to this email directly or view it on GitHub: https://github.com/lucaong/jQCloud/issues/24#issuecomment-7029566

lucaong commented 12 years ago

No, the cloud is not autoscaling at the moment, which makes the width and height property names quite confusing now, I admit that, as they only control the aspect ratio of the cloud, not the actual boundaries ;) Currently the only option is styling the cloud so that, with the typical number of word, it does not overflow. I have considered various options to autoscale, but so far I did not come up with a solution that does not introduce major drawbacks (like anything which is not pure HTML/CSS) or slows down the browser too much. If you have any idea on how that may be done efficiently you are very welcome :)

rsimon commented 12 years ago

Ok, that's cool then. I'll simply check how many "large" tags there are (since this is pretty much the primary decision factor in my case) and then limit the number of tags accordingly!

Cheers & thanks, Rainer

-----Ursprüngliche Nachricht----- Von: Luca Ongaro [mailto:reply@reply.github.com] Gesendet: Dienstag, 17. Juli 2012 11:04 An: Simon Rainer Betreff: Re: [jQCloud] Tag spacing messed up when used with Twitter Bootstrap (#24)

No, the cloud is not autoscaling at the moment, which makes the width and height property names quite confusing now, I admit that, as they only control the aspect ratio of the cloud, not the actual boundaries ;) Currently the only option is styling the cloud so that, with the typical number of word, it does not overflow. I have considered various options to autoscale, but so far I did not come up with a solution that does not introduce major drawbacks (like anything which is not pure HTML/CSS) or slows down the browser too much. If you have any idea on how that may be done efficiently you are very welcome :)


Reply to this email directly or view it on GitHub: https://github.com/lucaong/jQCloud/issues/24#issuecomment-7030114