add storeFields to types definition

lucaong / minisearch

Tiny and powerful JavaScript full-text search engine for browser and Node

https://lucaong.github.io/minisearch/

MIT License

4.83k stars 137 forks source link

add storeFields to types definition #20

Closed emilianox closed 5 years ago

emilianox commented 5 years ago

Hi! I think that you missed the property storeFields in the types declaration: can you add that? is in https://github.com/lucaong/minisearch/blob/02553c76068b3bdff4b5c8dcc81d20e12d3944f0/src/index.d.ts#L48

storeFields: string[],

thanks! BTW: love your work! amazing library!

lucaong commented 5 years ago

Ooops! Yes, absolutely, thanks for catching that. I miss storeFields and filter. I could add them myself at the beginning of next week (I am on vacation now), but I am happy to take pull-requests too.

emilianox commented 5 years ago

Great, im going to send a PR today or tomorrow

emilianox commented 5 years ago

https://github.com/lucaong/minisearch/pull/21

lucaong commented 5 years ago

I merged #21 and released version v2.1.1. Thanks @emilianox for your contribution!