search

lucaong / minisearch

Tiny and powerful JavaScript full-text search engine for browser and Node
https://lucaong.github.io/minisearch/
MIT License
4.83k stars 137 forks source link

TypeScript typings for storeFields #27

Closed ryan-codingintrigue closed 5 years ago

ryan-codingintrigue commented 5 years ago

I think the TypeScript typing for the storeFields property might be in the wrong place:

https://github.com/lucaong/minisearch/blob/25f9e04c7a12968ea4074019d820adbc792a381c/src/index.d.ts#L30

Should probably be in the plain Options interface:

https://github.com/lucaong/minisearch/blob/25f9e04c7a12968ea4074019d820adbc792a381c/src/index.d.ts#L51

Can file a PR if needed 😄

lucaong commented 5 years ago

Ooops... you're absolutely right!

Yes, a PR would be awesome 🙂

lucaong commented 5 years ago

Fixed by https://github.com/lucaong/minisearch/pull/28 (thanks again @ryan-codingintrigue), I just released v2.1.3 including this fix.