lucapette / fakedata

CLI utility for fake data generation
MIT License
200 stars 7 forks source link

Fixes #63 #64

Closed lucapette closed 7 years ago

lucapette commented 7 years ago

This bug was introduced with CustomFunc. Some generators accept input (we call the input "constraints") and, as of now, there's no way to run a custom generator with default input (the concept doesn't exist yet, defaults are hard coded inside the generators function).

I added a couple of simple integration tests to make sure we don't break it moving forward (to be honest, it's a very simple test but it gives us enough confidence things are glued together correctly for the -g flag).

The fact we can't run custom generators using the same function is a known desing limitation of fakedata. And this bug fix is a good reminder we should improve its design in this area.

@kevingimbel I did some minor cosmetic changes to the tests too. If you're fine with what I've done, feel free to merge it so I can cut a bug fix release :)