search

lucapinello / pyacaia

Python module to interact with Acaia scales via Bluetooth (BLE)
GNU Affero General Public License v3.0
53 stars 16 forks source link

Code cleanup, PEP8 styling #2

Closed JMY1000 closed 5 years ago

JMY1000 commented 5 years ago

Still maybe have some work to do.

lucapinello commented 5 years ago

Thanks! one thing important is that the pip version of bluepy as a bug. This clone is working well https://github.com/lucapinello/bluepy . Do you know how to link in the setup.py a github repo?

JMY1000 commented 5 years ago

Sorry, I'm not sure I understand what you're asking. Do you mean dependency links?

lucapinello commented 5 years ago

Yes!

I didn't know about this option...

On Tue, Oct 29, 2019 at 4:22 PM JMY1000 notifications@github.com wrote:

Sorry, I'm not sure I understand what you're asking. Do you mean dependency links? https://python-packaging.readthedocs.io/en/latest/dependencies.html#packages-not-on-pypi

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lucapinello/pyacaia/pull/2?email_source=notifications&email_token=AAIH72V26GSZ6FZB43E64TTQRCLO3A5CNFSM4JGOUVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECR6K2Y#issuecomment-547612011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIH72VSZROCOPG3EYARCF3QRCLO3ANCNFSM4JGOUVOA .

JMY1000 commented 5 years ago

It seems like if you can avoid doing that and use the PIP version it'd be better. Could a release with the fix be issued maybe?

lucapinello commented 5 years ago

In theory yes, the problem is that the project has several pull requests and not sure if it is maintained anymore at this point: https://github.com/IanHarvey/bluepy

On Tue, Oct 29, 2019 at 5:55 PM JMY1000 notifications@github.com wrote:

It seems like if you can avoid doing that and use the PIP version it'd be better. Could a release with the fix be issued maybe?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lucapinello/pyacaia/pull/2?email_source=notifications&email_token=AAIH72VMD7O3TCG4V2DPGMDQRCWMXA5CNFSM4JGOUVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSG4QQ#issuecomment-547647042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIH72TLNKQMISJZ6C2DRWLQRCWMXANCNFSM4JGOUVOA .

JMY1000 commented 5 years ago

I see. Maybe the correct answer is just to fork and take over the project? Seems like that should be handed in another PR though.

lucapinello commented 5 years ago

Unfortunately, I don't have the bandwidth to take over this project so I think the dependency links, for now, is the best option.

Thanks for taking the time to review my code!

Luca

On Tue, Oct 29, 2019 at 6:01 PM JMY1000 notifications@github.com wrote:

I see. Maybe the correct answer is just to fork and take over the project? Seems like that should be handed in another PR though.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/lucapinello/pyacaia/pull/2?email_source=notifications&email_token=AAIH72V66HELYLSY2GA2FCDQRCXC5A5CNFSM4JGOUVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSHLGY#issuecomment-547648923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIH72RS2MOLOJ7HFUU2FJDQRCXC5ANCNFSM4JGOUVOA .