search

lucas-jones / three-lightmap-baker

129 stars 9 forks source link

Example Map & Model Suggestions #2

Closed DennisSmolek closed 1 year ago

DennisSmolek commented 1 year ago

Hey man!

I'm really impressed with your work so far and I think there's a lot of people who would also be interested, especially with the utilization of three-mesh-bvh and the pathtracer..

There's been some great work on another lightmapper: https://github.com/pmndrs/react-three-lightmap And the article on it: https://unframework.com/portfolio/simple-global-illumination-lightmap-baker-for-threejs/

It seems there's a good amount of crossover with things on both libraries wishlists so I think worth looking into...

However... the main Demos**, (which are super awesome)

have some rights/src clearance issues that I think should get cleared up before it's shared or posted on showcases etc..

Something like THIS
Screen Shot 2022-09-20 at 13 05 26

Would probably be a good fit..

This is a cool rocky/alien arena

If this is just a personal thing then no worries! but I think it would fit in really well with some other amazing things happening in the JS/React/3D space if you're open to it..

Let me know what you think, I'm up to help however I can too if you need it.

Again, Really great work!

lucas-jones commented 1 year ago

Thank you! I will replace the copyrighted maps as this project has gained some interest

gkjohnson commented 1 year ago

There are also some similarities to @react-three-fiber/drei's <AccumulativeShadows> component:

All these libraries use a different approach (jittered light for soft shadows, light probes for the link in the OP) and should give a sense for how people are using these types of libraries already - but raytracing for light maps and AO baking should give the most robust solution at the cost of a bit of performance. Though should be possible to achieve a similar use experience.

lucas-jones commented 1 year ago

image

I've force pushed to remove the levels. I've added the one you linked :)

gkjohnson commented 1 year ago

Nice! One thing to note is the license of the linked models are "CC Attribution" which means you should at least credit the artist and maybe link to the sketchfab page somewhere in the README or example.

DennisSmolek commented 1 year ago

Awesome! and so fast too!

I saw the credit in the readme so I'll go ahead and close this,

Great Job!