search

lucasart / c-chess-cli

Command Line Interface for UCI Chess engines written in C
GNU General Public License v3.0
70 stars 9 forks source link

python version needed #45

Closed vondele closed 3 years ago

vondele commented 3 years ago

The build process seems to require python 3.7 or newer:

python3 make.py 
Traceback (most recent call last):
  File "make.py", line 14, in <module>
    version = subprocess.run(['git', 'show','-s','--format=%ci'], capture_output=True).stdout.split()[0].decode('utf-8')
  File "/usr/lib64/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'
vondele commented 3 years ago

using stdout=subprocess.PIPE, stderr=subprocess.PIPE instead of capture_output=True fixes it for me.

lucasart commented 3 years ago

fixed 2a2bdbd07ab3e85b65748853253b372864141f13

ppigazzini commented 3 years ago

I suggest to state the minimum python version supported. Pyhton 3.5 is EOL since September 2020 (see https://endoflife.date/python) and on Linux is easy to install any python distro/version with pyenv