search

lucasasselli / garmin-podcasts

Garmin Podcasts is a Garmin Connect IQ podcast app powered by Podcast Index. No external service or subscription required: all you need is you watch!
GNU General Public License v3.0
75 stars 16 forks source link

align episode download and subscription menus look and feel #27

Closed lucasnz closed 2 years ago

lucasnz commented 2 years ago

This PR makes the look and feel of the download and subscription menus the same - previously these was no visual feedback when clicking a subscription.

I don't understand the hasProgress variable (when is it set). Changing line 49 of EpisodeDownload.mc resolved an issue, where when exiting the subscribe screen it would drop you back into the main menu (instead of stepping back one screen). Why do we want to switchTo instead of show when hasProgress is true? Other changes should be less contentious (I think).

lucasasselli commented 2 years ago

hasProgress is set when doing a remote operation. It means that the progressBar is shown on screen and it has to be dismissed.