search

lucasb-eyer / pydensecrf

Python wrapper to Philipp Krähenbühl's dense (fully connected) CRFs with gaussian edge potentials.
MIT License
1.94k stars 414 forks source link

A couple README fixes for generic addPairwiseEnergy #1

Closed swehrwein closed 8 years ago

swehrwein commented 8 years ago

Two things in the documentation of the generic non-2D addPairwiseEnergy:

  1. The feature matrix needs to have shape (feature_dimensionality, npoints); the example previously had this transposed.
  2. The feature dimensionality is not necessarily equal to nlabels; I changed it to 5 from 3, because it was confusing for me to have these equal by coincidence in the example.
lucasb-eyer commented 8 years ago

You're absolutely correct. Sorry for confusing you, and thanks a lot for the fix!

lucasb-eyer commented 8 years ago

I should add that I didn't test the generic non-2D part much, feel free to open issues if you encounter more problems.