#4: Add Tests - Githubissues

lucasbento / react-native-thumbnail-video

Easily show thumbnails for videos on react-native.

MIT License

106 stars 36 forks source link

#4: Add Tests #5

Closed johncblandii closed 6 years ago

johncblandii commented 6 years ago

Feature

Needs tests before refactoring to support multiple video providers.

Solution

Split up code for easier testing
Added tests for youtube parsing
Added tests for Thumbnail component with snapshots and basic verification of statics
- TODOs
- Verify onPress
- Better verify the url

Resolves https://github.com/lucasbento/react-native-thumbnail-video/issues/4.

Notes

React and React Native were added as dependencies. I'm sure those versions need to change or be a bit loose. @lucasbento, looking for direction here.

johncblandii commented 6 years ago

@lucasbento, I took some liberties with code structure, etc. Feel free to command some changes in that area.

It seems to work as expected in Expo:

johncblandii commented 6 years ago

No prob on contributing. I didn't want to refactor for multiple providers without tests to validate functionality.

lucasbento commented 6 years ago

@johncblandii: can you fix the conflicts with src/index.js? I think we can it merged after that! 🎉

johncblandii commented 6 years ago

Since it had changes in index I had to merge across the files. The tests seemed to validate the functionality. I updated the tests to validate the new props since that broke the tests (yayyyyy...tests FTW; 😃 ).

Let me know your thoughts.