Open lucascomamala opened 2 years ago
:heavy_check_mark: Good job with issue description
There are some issues that you still need to work on to get this project approved, but you are almost there!
Check the comments under the review.
Team3
prefix should be removed.Setup, Fetch data, Lists render, Actions, Conditional components, Filters
. Something like so:Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @mihndim. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @lucascomamala ,
Great work on making the changes requested by a previous reviewer π You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Great job creating an Issueπ
[x] Like the previous reviewer mentioned kindly make sure you have 17 cards in your Kanban board
π . The cards for group tasks
and create basic structure for rockets
are missing. Kindly add them.
Missing Cards | Missing Cards |
---|---|
Check the comments under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
I started again with a new project and ran into the exact same issue which leads me to believe that it's the script that's not working properly. I went ahead and added the missing cards manually.
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
2 person team
https://github.com/lucascomamala/space-travelers-hub/projects/1