lucasdotvin / laravel-soulbscription

A straightforward interface to handle subscriptions and feature consumption.
https://soulbscription.lucas.vin
MIT License
601 stars 84 forks source link

Add support for laravel 10 #57

Closed omaressaouaf closed 1 year ago

omaressaouaf commented 1 year ago

This pull request bumps dependencies to support Laravel 10. it also modifies the run-tests.yml github action to run tests on Laravel 10 as well

lucasdotvin commented 1 year ago

Hey! Thanks for the contribution! I'm running some tests to ensure everything is working then it'll be merged!

omaressaouaf commented 1 year ago

This package depends on another package of yours (laravel-database-queries-counter) which itself needs to support Laravel 10. I opened another pull request on laravel-queries-counter to support Laravel 10. then if you can tag a release in order to come back to this one and modify the dependency

ejjaquet commented 1 year ago

Any news about this update? I really want to use this package, but it won't let me install on Laravel 10...

omaressaouaf commented 1 year ago

Unfortunately the maintainer does not respond. so i had to fork it and use my own repo

codecov[bot] commented 1 year ago

Codecov Report

Merging #57 (939c98d) into develop (82d5e3e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 939c98d differs from pull request most recent head c22d9bb. Consider uploading reports for the commit c22d9bb to get more accurate results

@@            Coverage Diff             @@
##             develop      #57   +/-   ##
==========================================
  Coverage      98.20%   98.20%           
  Complexity       150      150           
==========================================
  Files             26       26           
  Lines            501      501           
==========================================
  Hits             492      492           
  Misses             9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

omaressaouaf commented 1 year ago

I think everything is fine ?

lucasdotvin commented 1 year ago

For some reason, it is not running the test suite for PHP 8.1 with Laravel 10. I'm going to push another commit and see how it goes.

lucasdotvin commented 1 year ago

Thank you guys for your patience! 😅