search

lucasefe / themes_for_rails

Theme Support for Rails 3
This very same page :)
MIT License
308 stars 102 forks source link

Support for Rails 3.1 with asset pipeline disabled #39

Closed Dishwasha closed 12 years ago

Dishwasha commented 12 years ago

I find it amusingly coincidental that you worked on the rails31 upgrade on the exact same day that we had decided to upgrade to rails 3.1. Thanks for themes_for_rails as it has come in quite handy.

Since disabling the asset pipeline is an option in rails 3.1 and we're doing that as an interim step to our upgrade, I thought you might be interested in these changes. I know you probably wanted to get rid of some of the old stuff, but I pull some of it back in to allow themes_for_rails to support 3.1 with and without asset pipeline.

You could also relax the gemspec dependency to allow for version below 3.1, but I'd imagine it be just as easy for people not to upgrade beyond 0.4.2 on Rails 3.0.

If you like this, please let me know and I can modify the test suite to test in both conditions (asset pipeline enabled and disabled). Once again thanks and its good to see you're actively maintaining.

lucasefe commented 12 years ago

Ethan, sorry I did not apply this patch. I was traveling so I missed it.

Assets Pipeline on Rails 3.1 has been a pain in the ass. First attempt on Integrating ThemesForRails with this was a total fail, so I decided to put that on hold for now.

The current version (0.4.3) works properly with rails 3.1 and rails 3.2 (with some deprecation warnings). Master branch doesn't throw those messages.

Feel free to contact me about this any time you want.

Thanks