lucasefe / themes_for_rails

Theme Support for Rails 3
This very same page :)
MIT License
308 stars 102 forks source link

Digests for precompiled assets #54

Open idearise opened 12 years ago

idearise commented 12 years ago

It looks like the helpers (ex: theme_stylesheet_link_tag) are not returning asset digest urls for assets, although the digest versions are available.

For example:

<%= theme_stylesheet_link_tag "application" =%>

returns the following (no digest):

<link href="/assets/themename/stylesheets/application.css" media="screen" rel="stylesheet" type="text/css" />
idearise commented 12 years ago

This might help with obtaining the digest file names...A hash containing keys of precompiled assets with the values of their digest filenames is available through:

Rails.application.config.assets.digests
lucasefe commented 12 years ago

Is this happening on production? I think the digest version is only generated on production.

idearise commented 12 years ago

Digest versions are available in any environment where digest URLs enabled ( config.assets.digest = true ).

tkriplean commented 12 years ago

I'm just gonna add that this happens for me too: theme_stylesheet_link_tag is not linking to the available digest version in production.

I'm running themes_for_rails (0.5.1) & rails (3.2.6).

Thanks for the great gem @lucasefe, it is one of my favorites :-)

jasherai commented 12 years ago

@idearise I see you have a fork which is making use of the digests. Are there any issues outstanding that need addressing? I was about to attack this issue in much the same way and was wondering if there was anything I could help with?

lucasefe commented 12 years ago

@idearise And if so, why don't you do a Pull Request? Maybe w can merge it to master, man.

Thanks

danbronsema commented 12 years ago

Has this been pulled into the master? I'd love to get this working!

sweetroll commented 11 years ago

Would like to see this issue resolved too. Any chance of adding it in without @idearise pull request?

ksheurs commented 11 years ago

hey all, i will try and get tests working soon so i can do a pull request. sorry for the delay...

lucasefe commented 11 years ago

Hey, everyone, I'm looking for a maintainer of this gem. I have no time to dedicate to it, and I'm no longer using it, so if someone wants to step up, I'll be glad to provide help and support for the transition.

I don't want this project to die because of my inability of keeping up with the demand.

So, anyone is interested? If so, shoot me an email to lucasefe at gmail

Best

Lucas.