search

lucasferreira / react-native-send-intent

React Native Android module to use Android's Intent actions for send text to shareable apps or make phone calls or opening third party apps
419 stars 159 forks source link

Added support for automatically adding locations for events #17

Closed TheVaffel closed 8 years ago

TheVaffel commented 8 years ago

A small addition, allowing for automatic addition of location when saving events to the calendar

lucasferreira commented 8 years ago

Hi @TheVaffel

thanks for the contribution.

Could you please made this new "location" argument as a optionally filed in call?

Something like (config.location||null) and check != null in Java class file...

And if you could also add this new functionality in README file that will be great!

TheVaffel commented 8 years ago

Hi, thanks for the quick response!

I could add the checking, but the results from my tests suggest that it is unnecessary. If a location is not provided, the event will simply be created with no specified location. The same happens if you try omitting the title from the .js-file. The title simply becomes empty when the user is prompted by the calendar. I suppose putExtra() supports null values or something..

But I will change the README ASAP!

TheVaffel commented 8 years ago

Hi @lucasferreira , just in case you have forgotten, I am still waiting for this to be pulled :)

lucasferreira commented 8 years ago

Thanks @TheVaffel

I've already merged your pull request with master branch ;)