Added Camera method - Githubissues

lucasferreira / react-native-send-intent

React Native Android module to use Android's Intent actions for send text to shareable apps or make phone calls or opening third party apps

419 stars 159 forks source link

Closed misshannah closed 7 years ago

misshannah commented 7 years ago

Added a new method to open the camera on intent.

lucasferreira commented 7 years ago

Hi @misshannah

Can you remove from this pull the node_modules folder?

I recommend to you put this folder in your .gitignore file.

misshannah commented 7 years ago

Ok, I will do that.

lucasferreira commented 7 years ago

Hi @misshannah

Can you remove the folder "node_modules" from you PR?

misshannah commented 7 years ago

Hi @lucasferreira this is done. My apologies for the delay!

xvonabur commented 7 years ago

Hi @misshannah

Two things:

You need to rebase your previous commits, otherwise your node_modules stays in git repo history.
You forgot to update index.js file to include openCamera method.