search

lucasferreira / react-native-webview-android

Simple React Native Android module to use Android's WebView inside your app
355 stars 158 forks source link

Android 0.19.0 #31

Closed johntom closed 8 years ago

johntom commented 8 years ago

Hi, Followed all instructions 1) c:\React\NativeStarter>react-native run-android .... FAILURE: Build failed with an exception.

2) I got BUILD SUCCESSFUL with a secod attempt 3)react-native start but get the following on start image

Using RN 0.19.0 win10 genymotion Thanls. John

afeef commented 8 years ago

Hi @johntom I think you upgraded react-native from a previous version. Did you run react-native upgrade before starting the packager? See react-native upgrading guide here

johntom commented 8 years ago

Yes I did that and verified with npm info react-native|more. Perhaps I'm missing something. image

johntom commented 8 years ago

Also, I did get it to work with https://github.com/ivanph/react-native-webintent which is very similar to your repo for instructions. Please feel fee to close but I will followup if you want too. John

lucasferreira commented 8 years ago

Hi folks, the things change after react native 0.18.

I didn't have enough time to update the documentation but It's keep easy to load up the package inside a project.

Here we have more info https://facebook.github.io/react-native/docs/native-modules-android.html#content

dalgopower commented 8 years ago

yes..I tried your RN webview-android with RN 0.19 and couldn't get it working. MainActivity.java does not match the one on your Readme.md file.

so..I will try to follow this guide (https://facebook.github.io/react-native/docs/native-modules-android.html#content) as you mentioned above. However, I need little help.

In my understanding, I am supposed to.. 1) edit 'android/setting.gradle' as described in your document 2) edit 'android/app/build.gradle' as described in your document

3) create a class such as 'WebViewAndroidModule' (which extends ReactContextBaseJavaModule)

4) edit 'node_modules/react-native-webview-android/src/main/java/com/burnweb/rnwebview/main/RNWebViewPackage.java' file > 'createNativeModule' method to add that module from 1)

5) edit android/app/src/main/java/com/{my-app-name}/MainActivity.java' file > 'getPackages' to add RNWebViewPackage

ok...now I need ONE thing to know. where do I put WebViewAndroidModule.java file??? Is it supposed to be in...

a) node_modules/react-native-webview-android/src/main/java/com/burnweb/rnwebview/main/

b) android/app/src/main/java/com/{my-app-name}/

??

can you please help me out? thanks in advance

lucasferreira commented 8 years ago

Sorry folks, since react native 0.18 the README instructions are now obsolete. I didn't have enough time to update the instructions but in RN website have this path of upgrading.

Keep watch for my update in a few days (I am out in vacation right now, without any computer access :/)

Em quinta-feira, 11 de fevereiro de 2016, Ji Jimmy Youn < notifications@github.com> escreveu:

yes..I tried your RN webview-android with RN 0.19 and couldn't get it working. MainActivity.java does not match the one on your Readme.md file.

so..I will try to follow this guide ( https://facebook.github.io/react-native/docs/native-modules-android.html#content) as you mentioned above. However, I need little help.

In my understanding, I am supposed to.. 1) edit 'android/setting.gradle' as described in your document 2) edit 'android/app/build.gradle' as described in your document

3) create a class such as 'WebViewAndroidModule' (which extends ReactContextBaseJavaModule)

4) edit 'node_modules/react-native-webview-android/src/main/java/com/burnweb/rnwebview/main/RNWebViewPackage.java' file > 'createNativeModule' method to add that module from 1)

5) edit android/app/src/main/java/com/{my-app-name}/MainActivity.java' file > 'getPackages' to add RNWebViewPackage

ok...now I need to ONE thing. where do I put WebViewAndroidModule.java file??? Is it supposed to be in...

a) node_modules/react-native-webview-android/src/main/java/com/burnweb/rnwebview/main/

b) android/app/src/main/java/com/{my-app-name}/

??

thanks in advance

— Reply to this email directly or view it on GitHub https://github.com/lucasferreira/react-native-webview-android/issues/31#issuecomment-182872259 .

Sent from Gmail Mobile

lucasferreira commented 8 years ago

Hi @johntom and @dalgopower

I've updated the react-native-webview-android project and npm package.

I couldn't test on Windows right now, but in my mac, with ReactNative 0.20 it runs 100%.

I recommend you to install by npm install command, and use the configure/load proccess that I've updated inside the README.

lucasferreira commented 8 years ago

Hi @dalgopower

You have to use npm install react-native-webview-android inside the root of your RN project.

Before that you have to just load insider in your configs files as I recommend in README.

I don't need to create any Java files, all the things you need are embed inside react-native-webview-android package.