search

lucasgonze / Safeharbor.in

2 stars 0 forks source link

form markup in /settings breaks save #246

Closed lucasgonze closed 11 years ago

lucasgonze commented 11 years ago

In /settings, there are actually two forms, one for the top part and one for the bottom.

But from a functional and semantic perspective this breaks things. The user isn't expecting to submit the top with one button and the bottom with a different button. We could hack around this problem with javascript but this would be an excessively complex solution compared to just fixing the markup to reflect the reality that there should only be one form.

paigesaez commented 11 years ago

I'm confused. There are not two forms here. Only one. I see only one set of save|cancel buttons.

On Wed, Nov 7, 2012 at 3:47 PM, Lucas Gonze notifications@github.comwrote:

In /settings, there are actually two forms, one for the top part and one for the bottom.

But from a functional and semantic perspective this breaks things. The user isn't expecting to submit the top with one button and the bottom with a different button. We could hack around this problem with javascript but this would be an excessively complex solution compared to just fixing the markup to reflect the reality that there should only be one form.

— Reply to this email directly or view it on GitHubhttps://github.com/lucasgonze/Safeharbor.in/issues/246.

\\/////MAKERLAB/////\\ Love / Art / Architecture / Experience / Design / Research

Jellyfish Gallery 1286 Folsom St. SF, CA 94103

971-227-4384

m: paige@makerlab.com w: http://makerlab.com w: http://paigesaez.org t: http://blending.tumblr.com

lucasgonze commented 11 years ago

Not if you look in the markup. That's exactly the point.

In the markup there is

, but only one [save] button.

On Wed, Nov 7, 2012 at 4:30 PM, Paige Saez notifications@github.com wrote:

I'm confused. There are not two forms here. Only one. I see only one set of save|cancel buttons.

On Wed, Nov 7, 2012 at 3:47 PM, Lucas Gonze notifications@github.comwrote:

In /settings, there are actually two forms, one for the top part and one for the bottom.

But from a functional and semantic perspective this breaks things. The user isn't expecting to submit the top with one button and the bottom with a different button. We could hack around this problem with javascript but this would be an excessively complex solution compared to just fixing the markup to reflect the reality that there should only be one form.

— Reply to this email directly or view it on GitHub< https://github.com/lucasgonze/Safeharbor.in/issues/246>.

\\/////MAKERLAB/////\\ Love / Art / Architecture / Experience / Design / Research

Jellyfish Gallery 1286 Folsom St. SF, CA 94103

971-227-4384

m: paige@makerlab.com w: http://makerlab.com w: http://paigesaez.org t: http://blending.tumblr.com

— Reply to this email directly or view it on GitHubhttps://github.com/lucasgonze/Safeharbor.in/issues/246#issuecomment-10171397.

lucasgonze commented 11 years ago

Actually, don't worry about it. I can fix this.

Reassigning to myself.