lucasheld / ansible-uptime-kuma

Ansible collection of modules to configure Uptime Kuma
GNU General Public License v3.0
135 stars 19 forks source link

Status page: show clickable URL #30

Closed TheLastProject closed 10 months ago

TheLastProject commented 10 months ago

I think it would be great if we could set the "show clickable URL" setting on a monitor in the status page:

image

obfusk commented 10 months ago

Unless I overlooked something (I haven't tested this, just looked at the code), I think for that to work, sendUrl would need to be added to both of these (and the documentation):

TheLastProject commented 10 months ago

Sorry, those links aren't correct. It's not a monitor setting, it's a setting for an entry in the monitorList on the status page: https://github.com/lucasheld/ansible-uptime-kuma/wiki/status_page

obfusk commented 10 months ago

You are correct. It looks like the only change needed is ansible-uptime-kuma/plugins/modules/status_page.py -> main() -> module_args.

obfusk commented 10 months ago

AFAICT sendUrl is part of the monitor model in Uptime Kuma, which is why I thought it needed to be set there, but indeed to set it requires providing it via monitorList in saveStatusPage. Thanks for pointing that out :)

obfusk commented 10 months ago

We seem to be having a strange bug on our end after we tried using this. Unfortunately, we can't debug for another week. Will get back to you.

lucasheld commented 10 months ago

@obfusk Does the problem still exist? What kind of bug is it?

obfusk commented 10 months ago

@TheLastProject reported getting an error. But I tested it today and it seems to work fine :)