search

lucasheld / ansible-uptime-kuma

Ansible collection of modules to configure Uptime Kuma
GNU General Public License v3.0
135 stars 19 forks source link

Fix failing status_page test #35

Closed Javex closed 10 months ago

Javex commented 10 months ago

The test does not supply a sendUrl field which makes the test fail. By checking whether the key exists the test passes again.

While working on #34 I noticed that the test was failing so I think this should fix the problem. It was only introduced in #32 two weeks ago and probably slipped through.

Note that tests still fail currently due to https://github.com/lucasheld/uptime-kuma-api/pull/48 not being merged yet, but if you want the test to succeed, just run it against the louislam/uptime-kuma:1.22.1 image, that worked for me.

For some reason TestStatusPageInfo.test_all_status_pages also fails for me (but it does on master, too). I haven't investigated that failure yet.

lucasheld commented 10 months ago

Thanks! The TestStatusPageInfo.test_all_status_pages test also fails for me for a long time. I think this is because the events from Uptime Kuma do not arrive fast enough. But I haven't investigated it in detail yet either. There is no way to query the current list of status pages from uptime kuma. You have to rely on the events that come from uptime kuma when a new status page is added.