lucasheld / ansible-uptime-kuma

Ansible collection of modules to configure Uptime Kuma
GNU General Public License v3.0
135 stars 19 forks source link

Monitor lookup by name and parent #36

Closed nennad closed 9 months ago

nennad commented 10 months ago

Hi there, This pull request aims to fix the following issue: If you have two monitor groups called "Group A" and "Group B" and then you create a monitor called "API" inside "Group A", you will not be able to create a monitor with a name "API" inside "Group B" because the lookup for existing monitors is only taking into account the name of the monitor, and it will just move the existing "API" monitor from "Group A" to "Group B".

nennad commented 10 months ago

hey @lucasheld have you had a look at this by any chance? It would mean a lot for my team, we don't want to create a fork of your repo just because this one issue. If there's something wrong with the proposed changes please let me know and I'll try to fix it.