search

lucasheld / ansible-uptime-kuma

Ansible collection of modules to configure Uptime Kuma
GNU General Public License v3.0
135 stars 19 forks source link

Feature: Add showCertificateExpiry property to status_page module #40

Open BergCyrill opened 9 months ago

BergCyrill commented 9 months ago

While using your collection to configure an uptime instance and defining monitors & status page I came across the issue, that I cannot set the "showCertificateExpiry" property for a status page. A quick look into the API reference (here: https://uptime-kuma-api.readthedocs.io/en/latest/api.html#uptime_kuma_api.UptimeKumaApi.save_status_page) revealed that the API has indeed the capability to configure this.

In this PR I have created a quick implementation for this feature and also added it to the unit test. I have not tested it myself so far, I will add a comment to this PR.

Please have look - it would really help us to get this merged.

BergCyrill commented 9 months ago

We have tested the modification today and created two status pages using the modified module. It works as desired and sets the bool property for the status page.

BergCyrill commented 3 months ago

I know it’s bad style to comment for an update but since half a year has passed now - what prevents this PR from being merged?