search

lucasheld / uptime-kuma-api

A Python wrapper for the Uptime Kuma Socket.IO API
https://uptime-kuma-api.readthedocs.io
MIT License
269 stars 20 forks source link

support new showCertificateExpiry in status page JSON #48

Closed obfusk closed 1 year ago

obfusk commented 1 year ago

With latest uptime kuma (v1.23.0), we get this error:

TypeError: _build_status_page_data() got an unexpected keyword argument 'showCertificateExpiry'

There are a lot more changes of course, but this is the most obvious one that breaks the API, so hopefully this is enough to make it work again even if it doesn't support all other changes. Marked as draft for now as we haven't tested it yet.

obfusk commented 1 year ago

This fix seems to work, though obviously does not provide full support for the new version.

lucasheld commented 1 year ago

Uptime Kuma 1.23.1 is supported in version 1.2.0.

I decided to wait with the new release until the new version is fully supported. But I am unsure how to handle that in the future. My expectation was to wait with the Uptime Kuma update until uptime-kuma-api supports the new version.

obfusk commented 1 year ago

This was useful to us (and perhaps others) as a quick fix for the new version breaking our ansible deploy with 1.23.0, based on a quick evaluation that nothing else we were using seemed likely to break and that this change was sufficient to get it working with the new Uptime Kuma.

But I completely understand waiting to support the new version properly, and that support was implemented fairly quickly. Thank you!