search

lucashenning / logstash-filter-rest

REST Filter for Logstash
Other
43 stars 51 forks source link

Version/logstash 5 #13

Closed gandalfb closed 7 years ago

gandalfb commented 8 years ago

I wrote down the changes in the CHANGELOG and tested the common bug of not reassigning the fields with the commands in the README. For an easier usage of the Event API (#get, #set), a target needs to be defined. If it is needed in the event top-level, a mutate { rename => ... } after the rest { .. } might be suitable.

For now it looks good and the plugin can be run with logstash 5.0.0 With 2.x it is not executable anymore, so maybe #11 should be published as well.

Plugin version set to 0.5.0

lucashenning commented 8 years ago

Good job @gandalfb! It's good to see that the plugin is being maintained. My weeks are pretty packed at the moment but I'm gonna take care of #11 and #13 on the weekend. Thanks for your work!

pdesoyres commented 8 years ago

Thank you, this pull request is exactly what I need. @lucashenning, if you can find some time, I would really appreciate a merge of #11 and #13.