search

lucasjinreal / DCNv2_latest

DCNv2 supports decent pytorch such as torch 1.5+ (now 1.8+)
BSD 3-Clause "New" or "Revised" License
626 stars 124 forks source link

does it support pytorch1.7 preview version? #4

Closed splinter21 closed 3 years ago

lucasjinreal commented 4 years ago

Does pytorch 1.7 is out? Haven't tried it out, you can have a test, theoritically it should support.

seovchinnikov commented 4 years ago

They changed signatures in master in https://github.com/pytorch/pytorch/blob/v1.5.1/aten/src/THC/THCBlas.h

so THCudaBlas_Sgemv is not here. So it won't work in 1.6+

lucasjinreal commented 4 years ago

@seovchinnikov PR is welcome to support pytorch 1.6+

lucasjinreal commented 3 years ago

@seovchinnikov @splinter21 You can check pytorch1.6 branch to support pytorch1.6+

splinter21 commented 3 years ago

@seovchinnikov @splinter21 You can check pytorch1.6 branch to support pytorch1.6+

Ok, thanks!

austinmw commented 3 years ago

Hi, any updates on 1.7 support?

lucasjinreal commented 3 years ago

@austinmw You can try 1.6 branch? I suppose pytorch 1.7 should be same.

austinmw commented 3 years ago

@jinfagang 1.6 built successfully but 1.7 failed for me. I think there may be several deprecations.

I'd like to use the new distributed training enhancements of 1.7 so this would be very useful if you happen to get time to look into.

lucasjinreal commented 3 years ago

@austinmw Sure, I'll take some time to look, I shall upgrade to pytorch 1.7 as well.

nostayup commented 3 years ago

@austinmw Sure, I'll take some time to look, I shall upgrade to pytorch 1.7 as well.

Looking forward to your upgrade, it will be very useful

nmc-costa commented 3 years ago

Hello,

Thank you for the hard work, is it already update to pytorch 1.7?

lucasjinreal commented 3 years ago

@nmc-costa Will upgrade this week

lucasjinreal commented 3 years ago

@nmc-costa Works on pytorch 1.7 now.

nmc-costa commented 3 years ago

@jinfagang Thank you so much for the hard work. I will give it a try.

nmc-costa commented 3 years ago

Just in case someone has problems building, beware of the the GCC version and NVCC version, if GCC>=7, then NVCC>=10.