search

lucask07 / covg_fpga

FPGA and Python experiment code for the digital ion channel amplifier project.
GNU General Public License v3.0
6 stars 2 forks source link

Datastream #35

Closed lucask07 closed 1 year ago

lucask07 commented 1 year ago

Incorporate datastreams and writing datastreams to h5 files.

Ajstros commented 1 year ago

@lucask07 I've left a couple comments. The error with

daq.ADC_gp.sequencer_setup

won't let me finish running the bathclamp_vclamp_step_response.py file. It looks like we need to add that to pyripherals before merging this. Do you have a branch in pyripherals that addresses this? If not I can add a pull request there to add this functionality to the ADS8686.__init__ and ADS8686.setup_sequencer methods.

Ajstros commented 1 year ago

@lucask07 I have started a PR to add ADS8686.setup_sequencer in pyripherals: https://github.com/Ajstros/pyripherals/pull/30

I believe bathclamp_vclamp_step_response.py is running correctly using that branch of pyripherals, but I will wait for you to confirm that before I approve and merge this PR.