search

lucaslorentz / AS3SVGRenderer

An AS3 SVG Renderer for Flash Player.
106 stars 27 forks source link

Fix polyline fill - do not ignore the "fill" property. #35

Closed edzis closed 10 years ago

edzis commented 10 years ago

Is there a use case why we try to override the super getter?

lucaslorentz commented 10 years ago

If you have a polyline without fill (fill = none). When it is used as a clipPath, it should paint like if it were filled, to make the clipPath work. I think the correct thing to do would be override the method with the following logic:

return super.hasFill() || isInClipPath();

Unfortunately I don't have that on the test cases.

Sorry for the late answer, I'm not working on that project. When I have time I will install sdk, compiler and so on to help more.

lucaslorentz commented 10 years ago

Sorry, you were absolutely right, the base method already checks isInClipPath.