Update the whoami source

dervomsee commented 9 months ago

containous/whoami is deprecated and there is no arm image available. traefik/whoami should be used. grafik

lucaslorentz commented 9 months ago

Thanks for pointing that out!

2 thoughts about the change:

I know Traefik is a great project, but it is a direct competitor to Caddy, we can easily avoid doing free advertising by just picking another image, like hashicorp/http-echo. It doesn't support arm/v7 though, only arm64.
It would be nice to also update all other places that use containous/whoami, like tests in https://github.com/lucaslorentz/caddy-docker-proxy/tree/master/tests. I understand if you're not willing to all that change, I can do it in a separate PR later.

@francislavoie any thoughts about using Traefik image?

francislavoie commented 9 months ago

If the image is useful, there's no problem with using it IMO. It would be kinda petty to not use it just because of the org name 🤷‍♂️

lucaslorentz commented 9 months ago

@francislavoie Sounds good.

@dervomsee Would you kindly update the other occurrences of containous/whoami in the readme as well? No need to change tests folder, I can change that later.

dervomsee commented 9 months ago

No problem, I can update the files tomorrow. So traefik or a different project?

lucaslorentz commented 9 months ago

Traefik is good.

dervomsee commented 9 months ago

I updated the whoami source in all other files.

lucaslorentz / caddy-docker-proxy

Update the whoami source #566